Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix - fix no-deprecated bug #1786

Merged
merged 2 commits into from May 11, 2018
Merged

Hotfix - fix no-deprecated bug #1786

merged 2 commits into from May 11, 2018

Conversation

taddei
Copy link

@taddei taddei commented May 11, 2018 •
edited by ljharb

Fixes #1785

@taddei taddei mentioned this pull request May 11, 2018
Closed
ljharb
ljharb approved these changes May 11, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is good, but we'd need a regression test first.

@ljharb ljharb changed the title Hotifx - Issue:1785 - fixed no-deprecated bug Hotfix - fix no-deprecated bug May 11, 2018
@ljharb
Copy link
Member

ljharb commented May 11, 2018

k, i added a test thanks to your tip in the linked issue. will merge once tests pass.

@ljharb ljharb added the bug label May 11, 2018
@yannickcr
Copy link
Member

Thanks for your reactivity, I'll publish a patch release once this is merged.

@ljharb ljharb merged commit c29807c into jsx-eslint:master May 11, 2018
@yannickcr
Copy link
Member

v7.8.1 released 😄

@LINKIWI LINKIWI mentioned this pull request May 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taddei @ljharb @yannickcr