Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register prop-types when set through Flow SuperTypeParameters #1236

Merged
merged 1 commit into from Jun 8, 2017

Conversation

gpeal
Copy link
Contributor

@gpeal gpeal commented Jun 2, 2017

This picks up prop types when set using flow SuperTypeParameters such as:

type Props = { /* ... */ };

class MyComponent extends React.Component<void, Props, void> {
  ...
}

@ljharb This is modified from the property annotation checks. However, I couldn't test the wrapped TypeAnnotation or NullableTypeAnnotation resolution checks.

Signed-off-by: Gabriel Peal <gabriel.peal@airbnb.com>
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great!

@ljharb ljharb requested a review from yannickcr June 2, 2017 22:00
@ljharb
Copy link
Member

ljharb commented Jun 7, 2017

I'm going to merge this today if there's no objections.

@ljharb ljharb merged commit 52f54be into jsx-eslint:master Jun 8, 2017
@ljharb
Copy link
Member

ljharb commented Jun 8, 2017

@yannickcr any chance of a release soon, to get this fix in?

@jseminck jseminck mentioned this pull request Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants