-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsx-curly-brace-presence] Bail out in warning JSX expression when some chars exist #1458
Merged
ljharb
merged 8 commits into
jsx-eslint:master
from
jackyho112:make-jsx-curly-brace-presence-not-care-about-some-cases
Oct 17, 2017
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ad9aebe
Make jsx-curly-brace-presence bail out in getting rid of JSX expressi…
jackyho112 2bd2d07
Fix a typo in docs
jackyho112 af2fe6a
Take into account feedback
jackyho112 dc523b1
Add whitespace tests
jackyho112 8751e92
Bail out for line-breakers in JSX
jackyho112 c93dab8
Get rid of unnecessary regex
jackyho112 238140c
Add an author
jackyho112 c4ff64c
Improve a regex expression
jackyho112 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to escape line terminators here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually wanted to ask you about them. I know you mentioned them here.
I am not quite familiar with those. Do you type exactly those characters of any of the sets into the string to terminate a line? I tried having them in a JSX expression and it just displays those characters. Sorry about my lack of knowledge on the subject matter. 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Press the Enter key to type a LF (
\n
) (or most likely CRLF\r\n
on Windows).You can also run one of the following in the Chrome or Firefox dev tools console to copy the character to the clipboard:
copy('\n')
copy('\r')
copy('\u2028')
copy('\u2029')
Then you can simply paste the character.
But since the tests are written as JavaScript strings you should be able to use JavaScript escapes:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the example you mentioned, the output would be
<div propWithLineTerminators={"\\n\\r\\u2028\\u2029"}/>
? Because these characters would be displayed as they are in a JSX attribute.In that case, wouldn't the parser have already handled that?
For
<div propWithLineTerminators="\n\r\u2028\u2029"/>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think we should bail out if we find any line terminators at all, because of Babel's whitespace stripping thing.