Add instance-methods and instance-variables to sort-comp. #1470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljvdm
approved these changes
Oct 10, 2017
|
Hey guys, changes LGTM, let's get the ball rolling on merging this. |
|
Any updates on the merge? |
michaelhogg
added a commit
to michaelhogg/eslint-plugin-react
that referenced
this pull request
Apr 21, 2018
Regarding this issue:
jsx-eslint#599
sort-comp: Consider separating static fields & instance fields into separate groups
and this PR, released in v7.6.0:
jsx-eslint#1470
Add instance-methods and instance-variables to sort-comp.
there's a bug in the implementation of the `instance-methods` group.
Class instance methods can be declared in two different ways:
class Main extends React.Component {
// MethodDefinition -> FunctionExpression
foo() {}
// ClassProperty -> ArrowFunctionExpression
bar = () => {}
}
Using the `babel-eslint` parser, if a class instance method is
declared as a `FunctionExpression`, then the parent AST node is
a `MethodDefinition`, but the `sort-comp` rule is expecting the
parent node to be a `ClassProperty`, which is wrong.
|
FYI: discussion of this PR is continuing in #1774. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sorting of instance methods and instance variables optionally with the rules
instance-methodsandinstance-variablesrespectively. Rules are optional, and are applied immediately beforeeverything-elseto avoid overriding other rules.Adjusting
static-methodsand addingstatic-variableswould have been breaking so I skipped that for now.Fixes #599.