[new] add jsx-no-length-truthiness rule #2077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Dec 7, 2018
There was a problem hiding this comment.
While a rule to prevent this footgun might be useful, one that specifically focuses on length imo isn’t broad enough to be useful.
See #2073 as well (and generally it’s better to discuss new things on an issue before writing a PR; I’d hate you to feel like any work was in vain).
|
Doh, apologies, managed to completely miss that issue. Will continue discussion there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After managing to introduce code like this into the code base of two different clients (in spite of regularly teaching React courses that include a warning against exactly this)...
...I thought it was high time to prevent myself from getting a third strike. Hence this added rule!