Do not modify AST directly (fixes #249) #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, I added test to ensure the issue is fixed and it passed. I believe it's ready to merge. |
yannickcr
added a commit
that referenced
this pull request
Oct 18, 2015
Fix forbid-prop-types to do not modify AST directly (fixes #249)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #249.
The cause of the issue is that
checkForbidden()modifies AST. I fixed the issue by making local variablevalue.Note that this PR is work in progress. I don't commit test case yet. ButI'm already sure that the case reported in #249 was resolved.