Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] no-unused-prop-types: fix syntax errors #3259

Merged

Conversation

mrdulin
Copy link
Contributor

@mrdulin mrdulin commented Mar 29, 2022

No description provided.

ljharb
ljharb approved these changes Apr 1, 2022
Copy link
Member

@ljharb ljharb left a comment

Thanks!

firstname: string;
middlename: string; // middlename is never used by the Hello component
lastname: string;
Copy link
Member

@ljharb ljharb Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

technically these aren't syntax errors, but this is the more common TS style.

@ljharb ljharb force-pushed the fix/code-syntax-error-in-the-docs branch from e3114b3 to b9b1bee Compare Apr 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2022

Codecov Report

Merging #3259 (b9b1bee) into master (8513f1a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3259   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files         121      121           
  Lines        8584     8584           
  Branches     3117     3117           
=======================================
  Hits         8385     8385           
  Misses        199      199           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8513f1a...b9b1bee. Read the comment docs.

@ljharb ljharb changed the title fix: code syntax error in the docs [Docs] no-unused-prop-types: fix syntax errors Apr 1, 2022
@ljharb ljharb merged commit b9b1bee into jsx-eslint:master Apr 1, 2022
220 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants