Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] no-deprecated: improve performance #3271

Merged
merged 1 commit into from Apr 16, 2022

Conversation

golopot
Copy link
Contributor

@golopot golopot commented Apr 16, 2022

馃 Call getDeprecated for every MemberExpression.
馃檪 Call getDeprecated for every file linted.

Benchmark with TIMING=10 npx eslint .:

- react/no-deprecated                  |   658.734 |     4.8%
+ react/no-deprecated                  |   324.518 |     2.4%

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #3271 (7e4c2c2) into master (96b3b06) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3271      +/-   ##
==========================================
- Coverage   97.68%   97.68%   -0.01%     
==========================================
  Files         121      121              
  Lines        8593     8592       -1     
  Branches     3127     3127              
==========================================
- Hits         8394     8393       -1     
  Misses        199      199              
Impacted Files Coverage 螖
lib/rules/no-deprecated.js 97.97% <100.00%> (-0.03%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 96b3b06...7e4c2c2. Read the comment docs.

ljharb
ljharb approved these changes Apr 16, 2022
Copy link
Member

@ljharb ljharb left a comment

straightforward, nice

@ljharb ljharb merged commit 7e4c2c2 into jsx-eslint:master Apr 16, 2022
221 of 222 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants