Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] forbid-component-props: add disallowedFor option #3417

Merged

Conversation

jacketwpbb
Copy link

@jacketwpbb jacketwpbb commented Sep 7, 2022

Fixes #3422.

@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #3417 (2b0f500) into master (1fc7d34) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2b0f500 differs from pull request most recent head 4a92667. Consider uploading reports for the commit 4a92667 to get more accurate results

@@           Coverage Diff            @@
##           master    #3417    +/-   ##
========================================
  Coverage   97.62%   97.62%            
========================================
  Files         132      123     -9     
  Lines        9289     8964   -325     
  Branches     3396     3275   -121     
========================================
- Hits         9068     8751   -317     
+ Misses        221      213     -8     
Impacted Files Coverage Δ
lib/rules/forbid-component-props.js 100.00% <100.00%> (ø)

... and 50 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ljharb
Copy link
Member

ljharb commented Sep 7, 2022

#2946 was already resolved in #3338.

There isn't any consensus on doing anything further, so in the future, please do not send PRs for changes you're not sure are wanted.

In the meantime, let's leave this open, and please file a new issue so we can discuss if this is desired.

@ljharb ljharb marked this pull request as draft September 7, 2022 17:15
@jacketwpbb
Copy link
Author

Sorry,it was my first time to make a pull request, I have created a new issue for discussion.

ljharb and others added 2 commits April 14, 2023 12:35
Co-authored-by: jilianfeng <jilianfeng@baidu.com>
Co-authored-by: Ell Bradshaw <ellb@tailormed.co>
@ljharb ljharb force-pushed the add-disallow-list-for-component-props branch from 2b0f500 to 61d31b8 Compare April 14, 2023 19:42
@ljharb ljharb marked this pull request as ready for review April 14, 2023 19:43
@ljharb ljharb changed the title [New] forbid-component-props: add disallowedFor option [New] forbid-component-props: add disallowedFor option Apr 14, 2023
@ljharb ljharb force-pushed the add-disallow-list-for-component-props branch from 61d31b8 to 4a92667 Compare April 14, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add Rule option "disallowedFor" for component prop
3 participants