Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix noSortAlphabetically not respected in sort-prop-types #3609

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

caesar1030
Copy link
Contributor

Fixes #3591

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #3609 (8e9dd0f) into master (302925b) will increase coverage by 0.18%.
The diff coverage is 100.00%.

❗ Current head 8e9dd0f differs from pull request most recent head 3c11201. Consider uploading reports for the commit 3c11201 to get more accurate results

@@            Coverage Diff             @@
##           master    #3609      +/-   ##
==========================================
+ Coverage   97.44%   97.63%   +0.18%     
==========================================
  Files         132      132              
  Lines        9288     9296       +8     
  Branches     3394     3398       +4     
==========================================
+ Hits         9051     9076      +25     
+ Misses        237      220      -17     
Impacted Files Coverage Δ
lib/rules/sort-prop-types.js 98.27% <ø> (ø)
lib/util/propTypesSort.js 100.00% <100.00%> (+1.23%) ⬆️

... and 2 files with indirect coverage changes

@caesar1030 caesar1030 marked this pull request as draft July 22, 2023 08:22
@caesar1030 caesar1030 closed this Jul 22, 2023
@ljharb ljharb reopened this Jul 23, 2023
@ljharb ljharb merged commit 3c11201 into jsx-eslint:master Jul 24, 2023
585 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Fixer of sort-prop-types doesn’t respect noSortAlphabetically
2 participants