Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsx-filename-extension rule #560

Closed
wants to merge 1 commit into from

Conversation

lencioni
Copy link
Collaborator

Some projects want to require that any file that uses JSX to end in
.jsx, and others prefer to use .js. This rule can be used to enforce
this. I see this as complimentary to require-extension.

Fixes #495

Some projects want to require that any file that uses JSX to end in
.jsx, and others prefer to use .js. This rule can be used to enforce
this. I see this as complimentary to require-extension.

Fixes jsx-eslint#495
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 96.829% when pulling 2d96bd3 on lencioni:jsx-filename-extension into ffc2b9e on yannickcr:master.

@lencioni
Copy link
Collaborator Author

Are there any changes you'd like to see me make to this PR?

@yannickcr
Copy link
Member

Rebased and merged in fd35cbf, thanks!

@yannickcr yannickcr closed this Jun 5, 2016
@koistya
Copy link

koistya commented Aug 3, 2016

@lencioni do you use .jsx extension for React components at AirBnb?

@lencioni
Copy link
Collaborator Author

lencioni commented Aug 3, 2016

@koistya yes, we use .jsx for any file containing JSX.

@lencioni lencioni deleted the jsx-filename-extension branch August 3, 2016 14:49
@ljharb
Copy link
Member

ljharb commented Aug 3, 2016

@koistya v10.0 of eslint-config-airbnb also requires this.

@koistya
Copy link

koistya commented Aug 3, 2016

@lencioni @ljharb I guess you had seen the related discussion here already.

@lencioni
Copy link
Collaborator Author

lencioni commented Aug 3, 2016

@koistya Indeed, we have! See also: airbnb/javascript#985

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants