[added] react/ prefix to rule names #633
Conversation
The README didn't make it clear that rule names should be prefixed with `react/`, so I fixed it. Reasonable solutions: 1. Show an example `rules` block. 2. Add `react/` to each rule name in the index. I've done both here. Feel free to choose one or accept both. 😃
| The plugin has a [recommended configuration](#user-content-recommended-configuration) that enforces React good practices. | ||
| ```json | ||
| "rules": { | ||
| "react/jsx-uses-react": "warn", |
There was a problem hiding this comment.
if we're going to use an example, let's use "error" instead of "warn" - warnings are often ignored and thus mostly useless :-)
There was a problem hiding this comment.
Fixed.
Honestly, I wasn't sure what the right word was to use there. jsx-uses-react fixes eslint errors, rather than introducing them.
|
I think I like this change - it's a bit noisier but also more explicit. I'll let @yannickcr merge it, but it'd be good if @appsforartists wouldn't mind rebasing down to a single commit first? :-) |
|
@ljharb Isn't that what the squash and merge button is for? 😉 I've been lazy and just made these changes from the GitHub UI. |
|
It's what the "rebase and merge" button should be for :-p blindly squashing commits on merge messes with the changelog :-( but no worries if you're editing in the UI. |
|
Oh. I thought they fixed that. 😢 |
|
Thanks. It will really help those who are new to ESLint plugins. |
|
Glad I could be helpful!
Thanks for putting this module together, and for landing my patch. 😃
|
The README didn't make it clear that rule names should be prefixed with
react/, so I fixed it. Reasonable solutions:rulesblock.react/to each rule name in the index.I've done both here. Feel free to choose one or accept both. 😃