Jsx max props per line updates #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Oct 4, 2016
| }, { | ||
| code: [ | ||
| '<App', | ||
| ' foo={{', |
There was a problem hiding this comment.
Let's also include some tests where the tagname and first prop are on the same line, but there's another prop. Also, please add variants of all tests that include spread props
kentor
force-pushed
the
jsx-max-props-per-line-updates
branch
3 times, most recently
from
37629e7
to
f211e4e
Compare
ljharb
approved these changes
Oct 5, 2016
|
I think this is ready to be merged and should be merged. |
lencioni
approved these changes
Jan 29, 2017
|
|
||
| The following patterns are considered warnings: | ||
| ```jsx | ||
| // [1, {when: always}] |
There was a problem hiding this comment.
Should this be
// [1, {when: 'always'}]There was a problem hiding this comment.
Not sure. It's valid if we're talking yaml, but not if it's json/js format.
There was a problem hiding this comment.
I think json format is the most common by a massive amount, so that's the format we should stick to in docs.
kentor
force-pushed
the
jsx-max-props-per-line-updates
branch
from
f211e4e
to
7f44442
Compare
In this patch we now consider props to be on the same "line" if the line
of where one prop ends matches the line of where the next prop begins.
e.g.
```
<App foo={{
}} bar />
```
`foo` and `bar` are now considered to be on the same line. Previously,
we would only look at the line in which the prop begins.
If `when` is set to `multiline`, then this rule skips checking entirely if the jsx opening tag is a single line. Defaults `when` to `always` which is the current behavior.
Make sure it works when a prop is on the same line as the start line of the tag, as well as with spread props that spans multiple lines.
kentor
force-pushed
the
jsx-max-props-per-line-updates
branch
from
7f44442
to
b52f3b8
Compare
To be consistent with the "Rule Options" section and other docs
|
Any chance to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses parts of #878
will happily change option names