Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for BindExpression. #43

Merged
merged 2 commits into from
Aug 31, 2017
Merged

Add support for BindExpression. #43

merged 2 commits into from
Aug 31, 2017

Conversation

beefancohen
Copy link
Contributor

Fixes #33

@coveralls
Copy link

coveralls commented Jun 8, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 98.817% when pulling 78fc956 on bind-expression into c055fab on master.

@beefancohen beefancohen force-pushed the bind-expression branch 2 times, most recently from 19d15a9 to 9a0a80c Compare June 8, 2017 21:15
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 98.817% when pulling 9a0a80c on bind-expression into f84c0b3 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 98.817% when pulling 9a0a80c on bind-expression into f84c0b3 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 98.817% when pulling 9a0a80c on bind-expression into f84c0b3 on master.

@beefancohen beefancohen mentioned this pull request Jun 27, 2017
Closed
ljharb
ljharb approved these changes Jun 27, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to add a.b::c as a.b.c.bind(a.b), and ::a.b.c as a.b.c.bind(a.b) also, as a test case?

@yoavniran
Copy link

hi. any chance this will get in soon?

@beefancohen
Copy link
Contributor Author

hi @yoavniran thanks for the reminder, will try and pick it back up this week!

@cheton
Copy link

cheton commented Aug 29, 2017

Is there any update on this PR?

@beefancohen beefancohen merged commit d86339d into master Aug 31, 2017
@markduan markduan mentioned this pull request Sep 18, 2017
Closed
@ljharb ljharb deleted the bind-expression branch June 12, 2020 05:15
@ljharb ljharb mentioned this pull request Oct 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@beefancohen @coveralls @yoavniran @cheton @ljharb