Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] add OptionalCallExpression #99

Merged
merged 2 commits into from
May 25, 2020
Merged

[New] add OptionalCallExpression #99

merged 2 commits into from
May 25, 2020

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented May 12, 2020

Fixes #98.

Nullish coalescing will first require we update to babel 7.

@coveralls
Copy link

coveralls commented May 12, 2020 •
edited

Coverage Status

Coverage increased (+0.04%) to 98.551% when pulling 7ed1532 on nullish_optional into ef18995 on master.

@ljharb
Copy link
Member Author

ljharb commented May 12, 2020

On second thought, I can just represent the transformation manually, pending an update to babel 7.

beefancohen
beefancohen approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@beefancohen beefancohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ljharb ljharb force-pushed the nullish_optional branch 2 times, most recently from bf9eb73 to 084ba3b Compare May 24, 2020 22:01
@ljharb ljharb merged commit 084ba3b into master May 25, 2020
@ljharb ljharb deleted the nullish_optional branch May 25, 2020 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beefancohen beefancohen beefancohen approved these changes

@jessebeach jessebeach Awaiting requested review from jessebeach

Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The prop value with an expression type of OptionalCallExpression could not be resolved
3 participants
@ljharb @coveralls @beefancohen