Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when opening a muc that has users with a "|" in their nick #1050

Closed
poVoq opened this issue Aug 11, 2021 · 2 comments
Closed

Crash when opening a muc that has users with a "|" in their nick #1050

poVoq opened this issue Aug 11, 2021 · 2 comments
Labels
bug

Comments

@poVoq
Copy link
Contributor

poVoq commented Aug 11, 2021 •
edited
Loading

Expected behavior

Joining a muc should work regardless of the usernames.

Actual behavior

Joining a MUC that has a nickname like nick|bla crashes JSXC

Steps to reproduce the behavior

  1. Join a muc that has such user nick
  2. Crash

Environment

  • JSXC version: 4.3.1
  • Host system and version: custom
  • Browser vendor and version: Firefox latest

Logs

Error: Syntax error, unrecognized expression: .li[data-nickname=""nick|bla""]
@sualko sualko added the bug label Aug 25, 2021
@sualko
Copy link
Member

sualko commented Aug 25, 2021

Could it be that the nick was "nick|bla"?

@sualko sualko closed this as completed in 7ccc8ec Aug 25, 2021
@poVoq
Copy link
Contributor Author

poVoq commented Aug 25, 2021

I didn't see the extra " ", but not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@poVoq @sualko