[WIP] Message Archive Management (XEP-0313) #432

singh1114 · 2017-01-09T09:53:49Z

fix #150
Ref: http://xmpp.org/extensions/xep-0313.html

typo fix

…feature-mam

It adds some example code to fetch the message archive. It also discusses the general policy to be followed.

All the messages are now in the chatbox. Lot of work is still needed Make the use of rsm is still not made. Bower.json file is changed to so that the file is taken from strophe library. getHistory function is run when the GUI file in initWindow function

Also, the message structure in the comments which shows the structure of the message that we recieve when request is sent to the server

sualko · 2017-01-26T15:41:32Z

src/jsxc.lib.gui.js

@@ -2360,6 +2360,7 @@ jsxc.gui.window = {
    */
   open: function(bid) {
      var win = jsxc.gui.window.init(bid);
+      jsxc.xmpp.mam.getHistory(bid);


Please use an event handler for this. I think the appropriate event would be init.window.jsxc.

sualko · 2017-01-26T15:42:47Z

src/jsxc.lib.xmpp.mam.js

+  /*
+  To include the whole functionality of strophe-plugin we used self
+  */
+  var self = jsxc.xmpp.conn.mam;


self usually points to the home namespace. In this case it would be jsxc.xmpp.mam.

Should I use 'this' than?

sualko · 2017-01-26T15:44:45Z

src/jsxc.lib.xmpp.mam.js

+  /*
+  To include the whole functionality of strophe-plugin we used self
+  */
+  var self = jsxc.xmpp.conn.mam;


You have to make sure, that the connection has already be established. See e.g. jsxc.lib.xmpp.chatState.js#L17

sualko · 2017-01-26T15:51:45Z

src/jsxc.lib.xmpp.mam.js

+      /*
+      Check the direction of the message i.e. In which direction messages are exchanged.
+      */
+      if(bid === $(message).find("forwarded message").attr("to")){


Please use also the xml namespace to identify the forwarded element. See jsxc.lib.xmpp.js#L789.

This is always equal to "forwarded xmlns="urn:xmpp:forward:0"". What do we need to check here?

In the future there could be an element with the same name, but different behavior.

sualko · 2017-01-26T15:53:02Z

src/jsxc.lib.xmpp.mam.js

+      //console.log(message);
+      //console.log(mamUid);
+
+      jsxc.storage.setUserItem('msg', mamUid, msg);


This shouldn't be needed.

OK. This will be removed.

local storage removed extra comments removed

singh1114 · 2017-02-03T10:49:13Z

I can't get anything on the sorting of the messages. Please help!

sualko · 2017-02-06T10:08:56Z

If there is no sorting you have to implement it.

singh1114 · 2017-02-08T09:38:14Z

I have a doubt up here. I know the postMessage function can handle a single message at a time. So, how can I sort a single message?( Please tell me if I am wrong)

Also, used a logic like this....

I tweaked the code of getHistory function such that it can whenever a user clicked on the someone from the roster list, all the messages are stored in a list and at the end, they are transferred to the postMessage function.

I wasn't able to get the required output but I want to ask is it the right way of solving the problem?

Another way is to create a function for sorting and when all the messages are stored in a data structure by the function getHistory they can be passed to that sorting function and finally they can be passed one by one to the postMessage.

Also if someone can use the code written by me and see if the messages of MUC were retrieved or not it would be great.

sualko · 2017-02-08T13:56:47Z

I would tweak the _postMessage function to work in a similar fashion than jsxc.gui.roster.insert.

skyfox675 · 2017-02-08T14:19:57Z

Quick feature question: Are there plans to add an option either in settings (global) or on a per conversation/chat basis to set history (On | Off | Server Default | Recipient Setting)? This is a very nice feature, not sure the difficulty required to implement, just thought I would ask.

Thanks!

sualko · 2017-02-08T14:47:04Z

@skyfox675 Thanks for your request. We will keep this in mind.

A function named sortMessages is made to sort the messages. A empty list is used for the purpose

The data structure is again emptied so that the place is made for new messages to come in.

singh1114 · 2017-02-16T19:31:38Z

@sualko Can you check the sortMessages function. Have I done it correctly?

sualko · 2017-02-20T09:10:57Z

src/jsxc.lib.gui.js

+   },
+
+   sortMessages: function(message){
+      var messageArray = jsxc.options.allMessages;


Why do you save messages in the options object?

I was trying to do it in some other ways. For that, I initialized an empty data structure in a function. So whenever the function ran it again got initialized to empty.

For example: say I am declaring a variable in sortMessage function.
sortMessages: function(message) { var messageArray = [] }
So whenever the function ran it again got initialized to empty deleting all the messages.

If you have any other idea please share.

There has to be another solution, because this is 👎.

sualko · 2017-02-20T09:13:04Z

src/jsxc.lib.gui.js

+            firstMessage = true;
+         }
+         if (isNaN(message.stamp)) {
+            length = messageArray.length;


So when I working with the messages I found that the last incoming message is not a real message it is just a system message which says that all messages have been encountered. I also found that the stamp of the last message returns NaN. So I am using that to check few things.

I mean, length was defined a couple of lines above and I think it is never changed.

sualko · 2017-02-20T09:14:07Z

src/jsxc.lib.options.js

+    * Declare empty list to be used for sorting the messages 
+    *  
+   */
+   allMessages: [],


The options object is only for options and not arbitrary data.

Please suggest something.

sualko · 2017-02-20T09:18:46Z

Have I done it correctly?

I don't think so. It would be probably more elegant if you would handle the sorting at jsxc.lib.gui.js#L2803.

We also have to think about delayed messages, because with the new sorting function these will be maybe not visible to the user.

sualko · 2017-02-20T13:05:31Z

Maybe you should start with some simpler tasks, like our new starter issues, to get familiar with the code.

singh1114 · 2017-02-20T17:51:04Z

How about #341...?

sualko · 2017-03-16T12:23:34Z

I think we close this pr. Thanks for your effort.

singh1114 and others added 4 commits January 9, 2017 15:20

Adds the dependency of Message Archive management

0a20cd1

Adds the dependency of Result set management

cbc0be0

typo fix

8987501

Merge pull request #2 from developersarm/feature-mam

ce672ad

typo fix

sualko added the WIP label Jan 9, 2017

singh1114 and others added 12 commits January 11, 2017 17:09

adds the file src/jsxc.lib.xmpp.mam.js

b5d5e6c

Merge branch 'feature-mam' of https://github.com/singh1114/jsxc into …

0c243cc

…feature-mam

Merge branch 'master' into feature-mam

e76a1bf

changes file name

1f9701c

chages strophe.mam dependency

ecde12c

Adds general policy and code structure

8fd3e88

It adds some example code to fetch the message archive. It also discusses the general policy to be followed.

Updates subproject commits

c5422d6

Merge branch 'master' into feature-mam

f0c3aae

Merge remote-tracking branch 'upstream/master'

ba99b66

Merge branch 'master' into feature-mam

4dc3eb0

Adds the direction to msg object in getHistory function

494302d

Also, the message structure in the comments which shows the structure of the message that we recieve when request is sent to the server

sualko reviewed Jan 26, 2017

View reviewed changes

changes made after members review

9525f6f

local storage removed extra comments removed

Merge remote-tracking branch 'upstream/master'

e6a33f2

singh1114 added 3 commits February 17, 2017 00:34

merging master

93580ea

Adds a function for sorting

48a928f

A function named sortMessages is made to sort the messages. A empty list is used for the purpose

Empties the list again

7676a79

The data structure is again emptied so that the place is made for new messages to come in.

sualko reviewed Feb 20, 2017

View reviewed changes

sualko closed this Mar 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Message Archive Management (XEP-0313) #432

[WIP] Message Archive Management (XEP-0313) #432

singh1114 commented Jan 9, 2017 •

edited by sualko

sualko Jan 26, 2017

sualko Jan 26, 2017

singh1114 Jan 27, 2017

sualko Jan 30, 2017

sualko Jan 26, 2017

sualko Jan 26, 2017

singh1114 Jan 29, 2017 •

edited

sualko Jan 30, 2017

sualko Jan 26, 2017

singh1114 Jan 27, 2017

singh1114 commented Feb 3, 2017

sualko commented Feb 6, 2017

singh1114 commented Feb 8, 2017

sualko commented Feb 8, 2017

skyfox675 commented Feb 8, 2017 •

edited

sualko commented Feb 8, 2017

singh1114 commented Feb 16, 2017

sualko Feb 20, 2017

singh1114 Feb 20, 2017

sualko Feb 20, 2017

sualko Feb 20, 2017

singh1114 Feb 20, 2017

sualko Feb 20, 2017

sualko Feb 20, 2017

singh1114 Feb 20, 2017

sualko commented Feb 20, 2017

sualko commented Feb 20, 2017

singh1114 commented Feb 20, 2017 •

edited

sualko commented Mar 16, 2017

[WIP] Message Archive Management (XEP-0313) #432

[WIP] Message Archive Management (XEP-0313) #432

Conversation

singh1114 commented Jan 9, 2017 • edited by sualko

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

singh1114 Jan 29, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

singh1114 commented Feb 3, 2017

sualko commented Feb 6, 2017

singh1114 commented Feb 8, 2017

sualko commented Feb 8, 2017

skyfox675 commented Feb 8, 2017 • edited

sualko commented Feb 8, 2017

singh1114 commented Feb 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sualko commented Feb 20, 2017

sualko commented Feb 20, 2017

singh1114 commented Feb 20, 2017 • edited

sualko commented Mar 16, 2017

singh1114 commented Jan 9, 2017 •

edited by sualko

singh1114 Jan 29, 2017 •

edited

skyfox675 commented Feb 8, 2017 •

edited

singh1114 commented Feb 20, 2017 •

edited