Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore components which does not support DiscoInfo on determining MUC services at XMPP server #827

Conversation

pussbb
Copy link
Contributor

@pussbb pussbb commented Sep 10, 2019

Jitsi has speakerstats_component which is not support getting discoinfo and responses with

<iq xmlns="jabber:client" type="error" to="as@site.com/jsxc-6e71fee0" from="speakerstats.site.com" id="4bcd4257-0c2a-423a-b458-60b3d9079b8d:sendIQ">
<error type="cancel">
    <service-unavailable xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
</error>
</iq>

which is stopping searching for MUC component domain.

Following change set allows to ignore service-unavailable for components which does not support disco items request and will re-throw stanza item in something else happend.

@sualko
Copy link
Member

sualko commented Sep 23, 2019

According to XEP-0045: Multi-User Chat a MUC implementation MUST support Service Discovery (XEP-0030). Therefore we can safely ignore any failing disco request. Thanks for your pr.

@sualko sualko merged commit aeb85df into jsxc:master Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants