Support point and segment extrusion #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BarbourSmith
approved these changes
Apr 30, 2024
| @@ -13,7 +13,7 @@ See: [remesh](#https://raw.githubusercontent.com/jsxcad/JSxCAD/master/nb/api/rem | |||
| `; | |||
|
|
|||
| Box(40, 1, 5) | |||
| .and(bend(20)) | |||
| .And(y(20), bend(20)) | |||
There was a problem hiding this comment.
Does capital And do anything different?
There was a problem hiding this comment.
The capital forms only use the input shape for context.
So this produces two versions of Box(40, 1, 5) -- one translated, and one bent.
The lowercase form would produce three versions -- the original, the translated, and the bent.
| @@ -3,49 +3,128 @@ | |||
| #include "demesh_util.h" | |||
| #include "point_util.h" | |||
|
|
|||
| static int Bend(Geometry* geometry, double reference_radius) { | |||
| static int Bend(Geometry* geometry, double reference_radius, | |||
There was a problem hiding this comment.
What does bend do again?
There was a problem hiding this comment.
Applies a uniform curvature to the shape.
Effectively placing it along the perimeter of a circle of the given radius.
It's not quite what we generally want, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.