Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subsume TextColumn into StringColumn #1074

Closed
lwhite1 opened this issue Mar 29, 2022 · 3 comments
Closed

subsume TextColumn into StringColumn #1074

lwhite1 opened this issue Mar 29, 2022 · 3 comments
Milestone

Comments

@lwhite1
Copy link
Collaborator

lwhite1 commented Mar 29, 2022

It's not clear that there's any benefit to having two columns to handle strings. the implementation of StringColumn could probably treat the different approaches to managing memory as implementation details hidden from the user

@lwhite1
Copy link
Collaborator Author

lwhite1 commented Mar 31, 2022

one possible implementation would be to copy both columns with different names and create a new StringColumn that delegates to the other columns. We could make the inner columns protected so they don't pollute the API.

@lwhite1
Copy link
Collaborator Author

lwhite1 commented Apr 1, 2022

This will be almost certainly be a breaking change.

@lwhite1 lwhite1 added this to the V. 1.0 milestone Apr 3, 2022
@lwhite1
Copy link
Collaborator Author

lwhite1 commented May 1, 2022

implemented

@lwhite1 lwhite1 closed this as completed May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant