Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table.splitOn fails when the categorical column is a TextColumn #554

Closed
lwhite1 opened this issue Jul 16, 2019 · 1 comment
Closed

table.splitOn fails when the categorical column is a TextColumn #554

lwhite1 opened this issue Jul 16, 2019 · 1 comment

Comments

@lwhite1
Copy link
Collaborator

lwhite1 commented Jul 16, 2019

Not all categories in the textColumn are returned.

It is an open question whether textColumn should be "categorical"

It might be easiest to fix this by substituting a stringColumn in the splitOn method behind the scenes
lwhite1 added a commit that referenced this issue Aug 3, 2019
@lwhite1
Fix bug: table.splitOn fails when the categorical column is a TextCol…
52b654b 
…umn #554

Convert any textColumns to stringColumns before splitting tables to allow them to be used for subgroups, etc.
@lwhite1
Copy link
Collaborator Author

lwhite1 commented Aug 3, 2019

fixed

@lwhite1 lwhite1 closed this as completed Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lwhite1