Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when reading json array with incomplete rows #591

Merged
merged 1 commit into from Aug 14, 2019

Conversation

ryancerf
Copy link
Collaborator

Thanks for contributing.

Description

Fixes #588

Checks whether a json key exists before getting attempting to get it. If the key does not exist add missing a value.

Testing

Yes

Copy link
Collaborator

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this

Have you run mvn compile on the command line? I think the formatting doesn't quite match what I'd expect the Google formatting plugin to produce

@lwhite1 lwhite1 merged commit dfd1f92 into jtablesaw:master Aug 14, 2019
@ryancerf ryancerf deleted the json_reader_bug branch August 14, 2019 23:56
@ryancerf
Copy link
Collaborator Author

I did not run mvn compile. I can run it in the future. I thought you had the formatter as a post commit hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NullPointerException when reading json array with incomplete rows
3 participants