Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ability to read a csv from a url #650

Merged
merged 7 commits into from Sep 2, 2019
Merged

Improve ability to read a csv from a url #650

merged 7 commits into from Sep 2, 2019

Conversation

ryancerf
Copy link
Collaborator

Description

  • Add a read csv method that accepts a url.
  • Add java in memory file system library as a test dependency.
  • When reading a file from a url if the mime type is unrecognized try parsing it as a csv.

Testing

Yes. Added the first tests for DataFrame reader using jimfs. DataFrameReader needs some refactoring to be more testable.

@ryancerf ryancerf changed the title Read url csv Improve ability to read a csv from a url Aug 29, 2019
@lwhite1 lwhite1 merged commit e86b01a into jtablesaw:master Sep 2, 2019
@ryancerf ryancerf mentioned this pull request Sep 2, 2019
Closed
@ryancerf ryancerf deleted the read_url_csv branch September 3, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

@lwhite1 lwhite1 lwhite1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryancerf @benmccann @lwhite1