Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programs with identical output events should not count as bank conflicts #11

Closed
jtackaberry opened this issue Nov 26, 2017 · 2 comments
Closed
Labels

Comments

@jtackaberry
Copy link
Owner

If two banks on a track have a conflicting program number but the output events are the same, this shouldn't actually register as a bank conflict.

Real world example: SSS V1 Core and SSS V1 Decorative both contain sul pont. Since these are both CC32/18, the conflict isn't actually a problem.

@jtackaberry
Copy link
Owner Author

Counter argument: A1 Brass High and A1 Brass Low on same source channel. Both patches have program 1 for longs, and both emit CC32/1, But there are very different articulations: supposing the patches are on different channels, if program 1 is activated, which one should get it? This is a legitimate conflict.

Indeed, with the SSS example, it's just a coincidence that sul pont is the same articulation in both combination palettes.

The conflict logic does need to report both cases as conflicts. The better solution would be to fudge the program number in the decorative patch (as opposed to the core patch because based on the other sections in the library, core is the one with sul pont).

@jtackaberry jtackaberry added invalid and removed bug labels Dec 14, 2017
@jtackaberry
Copy link
Owner Author

I still buy the above counterargument. Closing as invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant