Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --metadata-protection #234

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add --metadata-protection #234

wants to merge 1 commit into from

Conversation

arkadiyt
Copy link

Adds a --metadata-protection flag for #212

@coveralls
Copy link

coveralls commented Oct 22, 2019 •
edited
Loading

Coverage Status

Coverage increased (+17.04%) to 36.519% when pulling 295d602 on arkadiyt:atetelman--metadata into c39e3cb on jtblin:master.

@SharpEdgeMarshall
Copy link
Collaborator

lgtm but please add tests

@arkadiyt arkadiyt force-pushed the atetelman--metadata branch 3 times, most recently from a7ffdfb to bd4ab8e Compare November 4, 2019 06:06
@arkadiyt
Copy link
Author

arkadiyt commented Nov 4, 2019

@SharpEdgeMarshall done

@arkadiyt
Copy link
Author

Friendly bump - I'm doubling kube2iam's test coverage here

@joshbranham
Copy link

bumping this, seems like a real easy security win here. Would love to see this moved forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arkadiyt @coveralls @SharpEdgeMarshall @joshbranham