Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting up chart docs #293

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Setting up chart docs #293

merged 2 commits into from
Dec 21, 2020

Conversation

jtblin
Copy link
Owner

@jtblin jtblin commented Dec 7, 2020

@jtblin
Copy link
Owner Author

jtblin commented Dec 7, 2020

@walkafwalka can you check that this is what's required for #288?

@coveralls
Copy link

coveralls commented Dec 7, 2020 •
edited

Coverage Status

Coverage remained the same at 19.481% when pulling 22e49e6 on gh-page-helm-chart into f7dc952 on master.

@marcgascon
Copy link

Hi @jtblin,

I will really appreciate that the chart can be publicly retrieved as soon as possible, because we are using kube2iam and I will not maintain the chart in our own repositories.

By reviewing the PR I found a typo in a filename: .github/workflows/lint-dcos.yaml --> .github/workflows/lint-docs.yaml

Thanks for the effort 😄

@walkafwalka
Copy link
Collaborator

@jtblin This looks correct to me.

@jtblin jtblin merged commit f3b2965 into master Dec 21, 2020
@jtblin jtblin deleted the gh-page-helm-chart branch December 21, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtblin @coveralls @marcgascon @walkafwalka