Skip to content

Commit

Permalink
Node 16 (as-pect#341)
Browse files Browse the repository at this point in the history
* experimental-wasm-bigint does not need for node 16 and above

* works?

* works?

* works?

* works?

* update

* more

* only test on node 16, but support 15

* fix: revert to use matrix

* fix: revert latest scripts

* Apply suggestions from code review

Co-authored-by: jtenner <tenner.joshua@gmail.com>

* fix: formatting

Co-authored-by: MaxGraey <maxgraey@gmail.com>
Co-authored-by: Willem Wyndham <willem@cs.umd.edu>
  • Loading branch information
3 people committed Apr 27, 2021
1 parent ace6f44 commit 044ca3a
Show file tree
Hide file tree
Showing 14 changed files with 1,784 additions and 1,151 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
name: Check syntax
strategy:
matrix:
node_version: ["15"]
node_version: ["16"]
steps:
- uses: actions/checkout@v1.0.0
- uses: dcodeIO/setup-node-nvm@master
Expand All @@ -26,7 +26,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
node_version: ["current", "lts_latest", "15"]
node_version: ["16"]
steps:
- uses: actions/checkout@v1.0.0
- uses: dcodeIO/setup-node-nvm@master
Expand Down
1,116 changes: 681 additions & 435 deletions package-lock.json

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,5 @@
"ts-jest": "^26.5.1",
"ts-node": "^9.1.1",
"typescript": "^4.1.3"
},
"dependencies": {}
}
}
2 changes: 1 addition & 1 deletion packages/cli/bin/asp
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ const args = [
...process.argv.slice(2),
]

if (nodeVersion >= 12) args.unshift("--experimental-wasm-bigint");
if (nodeVersion >= 12 && nodeVersion < 16) args.unshift("--experimental-wasm-bigint");
if (nodeVersion >= 13) args.unshift("--experimental-wasi-unstable-preview1");

const spawned = spawn("node", args, {
Expand Down
12 changes: 6 additions & 6 deletions packages/cli/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 044ca3a

Please sign in to comment.