[Fix] code coverage problem with nested groups

jtenner · Aug 22, 2019 · 12c47ca · 12c47ca
1 parent ad2b09e
commit 12c47ca
Show file tree

Hide file tree

Showing 9 changed files with 27 additions and 8 deletions.
diff --git a/packages/assembly/assembly/__tests__/unmanaged.spec.wat b/packages/assembly/assembly/__tests__/unmanaged.spec.wat
@@ -3294,6 +3294,7 @@
    i32.const 0
    i32.const 0
    call $~lib/rt/tlsf/__alloc
+   call $~lib/rt/pure/__retain
    local.set $0
   end
   local.get $0

diff --git a/packages/cli/lib/as-pect.cli.amd.js b/packages/cli/lib/as-pect.cli.amd.js
diff --git a/packages/cli/lib/util/CommandLineArg.js b/packages/cli/lib/util/CommandLineArg.js
diff --git a/packages/core/lib/as-pect.core.amd.d.ts.map b/packages/core/lib/as-pect.core.amd.d.ts.map
diff --git a/packages/core/lib/as-pect.core.amd.js b/packages/core/lib/as-pect.core.amd.js
diff --git a/packages/core/lib/test/TestCollector.js b/packages/core/lib/test/TestCollector.js
diff --git a/packages/core/lib/test/TestContext.js b/packages/core/lib/test/TestContext.js
diff --git a/packages/core/src/test/TestCollector.ts b/packages/core/src/test/TestCollector.ts
@@ -612,8 +612,10 @@ export class TestCollector {
    */
   private reportTest(testNamePointer: number, callback: number): void {
     const group = this.groupStack[this.groupStack.length - 1];
+    /* istanbul ignore next */
     if (!group.willRun) return;
     const name = this.getString(testNamePointer, "No test() name provided.");
+    /* istanbul ignore next */
     if (!this.testRegex.test(name)) return;
 
     const test = new TestResult();
@@ -668,8 +670,10 @@ export class TestCollector {
     message: number,
   ): void {
     const group = this.groupStack[this.groupStack.length - 1];
+    /* istanbul ignore next */
     if (!group.willRun) return;
     const name = this.getString(testNamePointer, "No test() name provided.");
+    /* istanbul ignore next */
     if (!this.testRegex.test(name)) return;
 
     const test = new TestResult();

diff --git a/packages/core/src/test/TestContext.ts b/packages/core/src/test/TestContext.ts
@@ -89,7 +89,9 @@ export class TestContext extends TestCollector {
 
   private runGroup(group: TestGroup): void {
     if (!group.willRun) {
+      /* istanbul ignore next */
       for (const child of group.children) {
+        /* istanbul ignore next */
         this.runGroup(child);
         /* istanbul ignore next */
         if (this.endGroup) return;