Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Man Page on Windows #93

Merged
merged 3 commits into from
Feb 5, 2021
Merged

Man Page on Windows #93

merged 3 commits into from
Feb 5, 2021

Conversation

thecliguy
Copy link
Contributor

Provides a means of viewing the contents of the man page on Windows.

@thecliguy thecliguy mentioned this pull request Feb 3, 2021
@codecov-io
Copy link

codecov-io commented Feb 4, 2021

Codecov Report

Merging #93 (d1c5c65) into master (7878d66) will decrease coverage by 0.93%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   78.19%   77.26%   -0.94%     
==========================================
  Files          30       30              
  Lines        2756     2797      +41     
==========================================
+ Hits         2155     2161       +6     
- Misses        601      636      +35     
Impacted Files Coverage Δ
src/ssh_audit/ssh_audit.py 58.79% <16.66%> (-2.56%) ⬇️
src/ssh_audit/auditconf.py 97.40% <100.00%> (+0.03%) ⬆️
src/ssh_audit/globals.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7878d66...d1c5c65. Read the comment docs.

@thecliguy
Copy link
Contributor Author

Please review this PR when you get a chance. Send me any questions or feedback as necessary...

An MIT license and copyright header needs to be added to update_windows_man_page.sh. Since this is a new script that I've created should I add my name as the author to the copyright notice or Joe Testa (jtesta@positronsecurity.com)? I don't know what the correct etiquette is.

@jtesta jtesta merged commit 090b5d7 into jtesta:master Feb 5, 2021
@thecliguy thecliguy deleted the windows_man_page branch February 6, 2021 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants