Skip to content

Commit

Permalink
fix!: sync with kit@1.1.1 based on (PRs #194 #200) (#203)
Browse files Browse the repository at this point in the history
* chore: bump asdf tools

* chore: bump dependencies

* chore: apply xojs fixes

* test: bump test functions to nodejs18

* test: bump test deps & devdeps

* fix: rm check of runtime version assume nodejs18

* docs: update compat table

* test: fix end-to-end test firebase config

* chore(deps): Bump kit v1.1.1; ava, xo, esbuild, firebase-functions

* fix(lint): Use explicit `import type` statement

* fix(lint): Use the preferred nullish coalescing op over ternary

* test(version): Switch to `checkout@v3` to get rid of Node.js 12 warnings

* feat: Add Node.js 18 support

* fix: Missing 2nd argument for  (reading 'prerendering' error)

* fix(#200/@AndrewLester): Write prerendered fiels to public directory

* test(version): Add Node.js 18 to test cases

* fix(test): Add static route for `/about`. Switch from Svelte demo -> sverdle

* fix(test): Missing quote in `firebase.json`. Change label in test from Todos to Sverdle

Co-authored-by: Paul Pham <paul@aquaron.com>
  • Loading branch information
jthegedus and pham committed Jan 17, 2023
1 parent a4b4daa commit 352072d
Show file tree
Hide file tree
Showing 17 changed files with 1,253 additions and 1,524 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
unit:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: install asdf
uses: asdf-vm/actions/install@v1
- run: pnpm install
Expand Down Expand Up @@ -47,7 +47,7 @@ jobs:
nested_dir: ".",
}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: install asdf
uses: asdf-vm/actions/install@v1
- name: Run Integration test for ${{ matrix.params.test_dir }}
Expand All @@ -59,7 +59,7 @@ jobs:
needs:
- unit
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: install asdf
uses: asdf-vm/actions/install@v1
- name: Cache firebase emulators
Expand Down
6 changes: 3 additions & 3 deletions .tool-versions
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
firebase 11.6.0
nodejs 16.16.0
pnpm 7.9.1
firebase 11.18.0
nodejs 18.12.1
pnpm 7.18.2

# use for Firebase Emulator

Expand Down
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,21 @@ Cloud Functions!

## Contents

- [Contents](#contents)
- [Setup](#setup)
- [Beta Adapter Version Compatibility](#beta-adapter-version-compatibility)
- [Configuration Overview](#configuration-overview)
- [Details](#details)
- [`firebase.json` Configurations](#firebasejson-configurations)
- [Adapter Configurations](#adapter-configurations)
- [How it works](#how-it-works)
- [Firebase Emulator local Testing](#cloud-function-firebase-emulator-local-testing)
- [Firebase Emulator local Testing](#firebase-emulator-local-testing)
- [Deployment](#deployment)
- [Caveats](#caveats)
- [Non-Goals](#non-goals)
- [Non-goals](#non-goals)
- [FAQ](#faq)
- [Contributing](#contributing)
- [external contributions](#external-contributions)

## Setup

Expand Down Expand Up @@ -86,6 +88,7 @@ the Adapter and SvelteKit becoming incompatible. Here is a compatibility table:

| Adapter Version | SvelteKit Version |
| --------------- | -------------------- |
| `0.14.5` | `1.0.0-next.587` |
| `0.14.4` | `1.0.0-next.443` |
| `0.14.3` | `1.0.0-next.443` |
| `0.14.2` | `1.0.0-next.405` |
Expand Down Expand Up @@ -531,7 +534,7 @@ import/require of the generated code will not change unless you change the
`firebase.json:hosting.site` or `package.json:main` fields, so you shouldn't
need to update this code after adding it.

## Cloud Function Firebase Emulator local Testing
## Firebase Emulator local Testing

Test your production build locally before pushing to git or deploying!

Expand Down
12 changes: 6 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,18 @@
"node": "^14.13.1 || >= 16"
},
"dependencies": {
"esbuild": "^0.15.2"
"esbuild": "^0.17.0"
},
"peerDependencies": {
"@sveltejs/kit": "^1.0.0-next.443"
"@sveltejs/kit": "^1.0.0-next.587"
},
"devDependencies": {
"@sveltejs/kit": "^1.0.0-next.443",
"@sveltejs/kit": "^1.1.1",
"@types/express": "^4.17.13",
"@types/node": "^18.7.3",
"ava": "^4.3.1",
"firebase-functions": "^3.22.0",
"xo": "^0.51.0"
"ava": "^5.1.1",
"firebase-functions": "^4.1.1",
"xo": "^0.53.1"
},
"scripts": {
"fix": "xo --fix",
Expand Down
Loading

0 comments on commit 352072d

Please sign in to comment.