Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/libs #18

Merged
merged 48 commits into from
Dec 30, 2015
Merged

Feature/libs #18

merged 48 commits into from
Dec 30, 2015

Conversation

jtilly
Copy link
Owner

@jtilly jtilly commented Dec 26, 2015

Just checking if this could work. I'm now shipping all required petsc headers and libraries as part of the package. I probably have to add more libraries in case the system's default libraries are not the same that I used to compile petsc.

@jtilly
Copy link
Owner Author

jtilly commented Dec 26, 2015

This kinda works on my systems (and on Docker and travis). Have to set LD_LIBRARY_PATH by hand, but that could be fixed using a configure script.

@njanetos
Copy link
Collaborator

If we can get some compiled windows binaries, and figure out how windows batch scripting works, can we do the same trick with configure.win?

@jtilly
Copy link
Owner Author

jtilly commented Dec 27, 2015

I don't know. Take a look at the Rblapi package and see how they dealt with
the windows dlls. They didn't use the configure script for windows. Also
not sure how difficult it is to make a windows dll in the first place.
On Dec 27, 2015 8:30 AM, "Nick Janetos" notifications@github.com wrote:

If we can get some compiled windows binaries, and figure out how windows
batch scripting works, can we do the same trick with configure.win?


Reply to this email directly or view it on GitHub
#18 (comment).

jtilly added a commit that referenced this pull request Dec 30, 2015
Use configure script to download PETSc binaries or build PETSc as part of the installation.
@jtilly jtilly merged commit 167f9fd into master Dec 30, 2015
@jtilly jtilly deleted the feature/libs branch December 30, 2015 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants