-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to gimp 2.99.18 #2
Conversation
Co-Authored-By: Linus Heckemann <git@sphalerite.org>
https://www.gimp.org/news/2022/08/27/gimp-2-99-12-released/ GNOME/gimp@256b2d9...a791151 Introduces `gimp-script-fu-interpreter-3.0` as interpreter invoked by shebang of some plug-ins. Let’s ensure it is on `PATH`.
GNOME GitLab instance fails with “fatal: the remote end hung up unexpectedly”
GNOME/gimp@a791151...ad7a2e5 Adds OpenMP support.
7af6983
to
90ec4c4
Compare
, libilbm | ||
, libiff | ||
, cfitsio | ||
, gnome-icon-theme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just Adwaita alias that should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that, seeing as having adwaita as a dependency doesn't fix the tests, maybe I should remove both of these references for now?
@@ -186,9 +190,13 @@ in stdenv.mkDerivation (finalAttrs: { | |||
glib-networking | |||
libmypaint | |||
mypaint-brushes1 | |||
libilbm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be conditional too then.
, autoreconfHook | ||
}: | ||
|
||
stdenv.mkDerivation rec { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please open a PR against Nixpkgs adding these libraries? I can merge that and then rebase the GIMP PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dfb924a
to
5267785
Compare
Closing, as discussed. |
Update to 2.99.18
Had to disable the test suite again, for the same reason as it was disabled before, a missing icon in the open/save dialog.
@jtojnar