Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Add Huff implementation #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

♻️ Add Huff implementation #4

wants to merge 1 commit into from
+232 −0

Conversation

PraneshASP
Copy link

No description provided.

@PraneshASP
Copy link
Author

bump @jtriley-eth :))

@jtriley-eth
Copy link
Owner

sweet, ty for the bump

could you add tests to this? it can follow a similar strat to the vyper ipml:

  • create test/mock/ERC6909Mock.huff
  • compile this and put the initcode into test/mock/ERC6909MockHuff.sol
  • create test/alt/ERC6909Huff.t.sol
  • use the same tests as the others, just add the huff deployment in there

the reasoning for the compiled version is to make sure anyone can run forge t without huffc or vyper in the path

Repository owner deleted a comment Jan 2, 2024
Repository owner deleted a comment Jan 2, 2024
Repository owner deleted a comment from YuriyEmpty Jan 24, 2024
Repository owner deleted a comment from sabrinekhoualdi Feb 23, 2024
Repository owner deleted a comment from zmh-program Feb 23, 2024
Repository owner deleted a comment Mar 1, 2024
Repository owner deleted a comment from jalamari2018 Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PraneshASP @jtriley-eth