Remove global side effects to socket library #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the get_ip_info function used `socket.setdefaulttimeout` to set the socket timeout for its query socket. This function sets the default socket timeout globally, and thus caused side effects after this function was called. This change removes the previous setdefaulttimeout call in favor of setting the timeout directly on the socket itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the get_ip_info function used
socket.setdefaulttimeouttoset the socket timeout for its query socket. This function sets the
default socket timeout globally, and thus caused side effects after this
function was called (in any library or code that uses sockets).
This change removes the previous setdefaulttimeout call in favor of
setting the timeout directly on the socket itself.