Use angle-bracket includes to allow flexibile placement of dependencies #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hadn't caught the bad FAST5_INCLUDE variable at first since I was using an external copy of fast5, but everything looks good now. |
Hard-coding the relative paths to the header files impedes flexibility in using externally located versions of the headers.
|
I've simplified this PR and squashed it into one commit. My changes to the htslib include statements were not really necessary because, with double quotes, the header search path is used if the relative path isn't valid. The changes to the fast5 include statements adds flexibility, so I hope you will consider merging it. |
|
Thanks - I'm on vacation right now but I'll try to merge this soon. I'll also look at the other PR you submitted too. I appreciate the contribution |
|
Thanks again for the PR |
|
No problem. Thanks for merging it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using -I in the C preprocessor flags adds the specified directories
to the search path. Taking advantage of this, we can use angle-brackets
for the include statements to avoid hardcoding the location of dependencies and
to ease use of externally installed versions.