Fix for Date is not loaded correctly bug #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
date string. Don't bother parsing string if invalid.
|
Yarg, long weekend with only a netbook - glanced at what you did, looks great, I'll try and get the merge in tommorow. Thanks! |
jtsage
added a commit
that referenced
this pull request
Apr 26, 2011
Fix for Date is not loaded correctly bug
|
Very nice, added! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #8
I think the bug wasn't just a mobile Safari issue. I was also getting days off by one in the picker with Firefox. Looks like 2011-01-01 isn't a support string format. You can avoid the format issues by changing:
to:
Tested on a Mac with Firefox4, Desktop Safari, iPhone simulator, and an iPhone4.