Fix string conversion of "1" to bool.

Fixes #152.
jtv · Feb 1, 2019 · 19cd381 · 19cd381
1 parent 849af9d
commit 19cd381
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/NEWS b/NEWS
@@ -12,6 +12,7 @@
  - Fix nested project builds in CMake.  Thanks Andrew Brownsword.
  - In Visual Studio, build for host architecture, not "x64".
  - Fix string conversion link error in Visual Studio.  Thanks Ivan Poiakov.
+ - Fix string conversion to bool for "1".  Thanks Amaracs.
  - Fix in escaping of strings in arrays.  Thanks smirql.
  - Faster copying of results of large queries.  Thanks Vsevolod Strukchinsky.
  - Starting to handle encodings properly!  Thanks to Joseph Durel.

diff --git a/src/strconv.cxx b/src/strconv.cxx
@@ -345,7 +345,7 @@ void string_traits<bool>::from_string(const char Str[], bool &Obj)
 
   case '1':
     result = true;
-    OK = (Str[1] != '\0');
+    OK = (Str[1] == '\0');
     break;
 
   case 't':