Skip to content

Commit

Permalink
Remove problematic initialiser altogether.
Browse files Browse the repository at this point in the history
There was no need for this base-class initialiser except to avoid a
warning in some very old gcc versions, so might as well get rid of it
altogether.

Also, documented the problem so we don't fall for it again.
  • Loading branch information
jtv committed Jan 24, 2019
1 parent de7c641 commit 6903d5e
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/strconv.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,10 @@ bool valid_infinity_string(const char str[]) noexcept
template<typename T> class dumb_stringstream : public std::stringstream
{
public:
dumb_stringstream() : std::stringstream()
// Do not initialise the base-class object using "stringstream{}" (with curly
// braces): that breaks on Visual C++. The classic "stringstream()" syntax
// (with parentheses) does work.
dumb_stringstream()
{
this->imbue(std::locale::classic());

Expand Down

0 comments on commit 6903d5e

Please sign in to comment.