Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on g++ version < 10. #665

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

skasperski
Copy link
Contributor

Build failed on test/unit/test_range.cpp because of what seems to be a bug in g++ < 10. It just moves the member declaration to the top of the templates. If it does not cause any other issue, might be worth for increased compatibility.

libpqxx/test/unit/test_range.cxx:1:
/libpqxx/include/pqxx/range.hxx:56:31: error: ‘m_value’ was not declared in this scope; did you mean ‘value’?
   56 |     noexcept(noexcept(value < m_value))
      |                               ^~~~~~~
      |                               value

@jtv jtv merged commit 8b87309 into jtv:master Mar 24, 2023
@jtv
Copy link
Owner

jtv commented Mar 24, 2023

Weird. Thanks for the fix! I'll add comments so we don't forget to change it back later.

jtv added a commit that referenced this pull request Mar 24, 2023
Note the changes for #664 & #665 in the appropriate places.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants