Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix std::functional problems. #677

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Fix std::functional problems. #677

merged 4 commits into from
Apr 24, 2023

Commits on Apr 22, 2023

  1. Fix std::functional problems. 

    Thanks @KayEss for pointing out that I shouldn't be using a
`std::function` as a deleter for a `std::shared_ptr` or
std::unique_ptr`.  Using ordinary function pointers instead.

Also, finally figured out how to work around a bunch of gcc compile
errors when I combined...
* The address sanitizer or "asan" (`-fsanitize=address`).
* Warnings as errors (`-Werror`).
* Uninitialized analyzer (`-Wanalyzer-use-of-uninitialized-value`).

Unfortunately, the combination of audit mode (`--enable-audit` in the
`configure` script) and maintainer mode (`--enable-maintainer-mode`
in the `configure` script) got us into exactly that combination.

It would seem that there's a problem with gcc.  It doesn't happen in
clang.  I worked around it by replacing the one regex in the code with
a manual parsing loop like I used to have.
    @jtv
    jtv committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    8cecf4e View commit details
    Browse the repository at this point in the history

  2. Fix signedness warning.

    @jtv
    jtv committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    555023b View commit details
    Browse the repository at this point in the history

  3. Move pqfreemem.

    @jtv
    jtv committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    c5c40f4 View commit details
    Browse the repository at this point in the history

  4. Comment.

    @jtv
    jtv committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    e0e219d View commit details
    Browse the repository at this point in the history