Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of set with extends tag #154

Closed
wants to merge 1 commit into from
Closed

Allow use of set with extends tag #154

wants to merge 1 commit into from

Conversation

thomas-p-wilson
Copy link

Quick but effective. As we discover other tags that can be used in conjunction with the extends tag, we can easily add them by simply modifying the JtwigContentParser accordingly.

@joao-de-melo
Copy link
Member

Thomas this one is failing on travis CI.
Could you also explain me this PR?

@coveralls
Copy link

Coverage Status

Coverage increased (+1.23%) when pulling 7ed388a on thomas-p-wilson:extends-set-tag into c6d84ea on lyncode:master.

@thomas-p-wilson
Copy link
Author

Missed this, sorry @lyncodev. Travis is saying the build is good, so I'm not sure what the problem was. This allows the use of the set tag before the extends tag. Previously set could only be used after.

@joao-de-melo joao-de-melo added this to the 3.1.0 milestone Oct 27, 2014
@joao-de-melo
Copy link
Member

Needs re-work.

@thomas-p-wilson
Copy link
Author

Not surprised. I vaguely recall screwing up something :D I'll have at it
again.

On Mon, Oct 27, 2014 at 5:51 PM, João Melo notifications@github.com wrote:

Needs re-work.


Reply to this email directly or view it on GitHub
https://github.com/lyncode/jtwig/pull/154#issuecomment-60675934.

@joao-de-melo
Copy link
Member

@thomas-p-wilson cannot find the source repo here (I was trying to pull the code and merge it).

@thomas-p-wilson thomas-p-wilson removed their assignment Nov 30, 2014
@joao-de-melo joao-de-melo modified the milestones: 4.0.0, 3.1.0 Nov 30, 2014
@thomas-p-wilson
Copy link
Author

This matter is now addressed as a result of #257, pending approval of course. And given that I can't find my original branch for this PR, I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants