Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extractor refactoring - ability to use static fields/methods #301

Closed
wants to merge 7 commits into from

Conversation

EvSpirit
Copy link

Working further on #300

I've done a bit of refactoring to solve a couple of issues:

  • Impossible to use static fields/methods (e.g. String.valueOf() or Integer.MAX_VALUE)
  • Incorrect method selection - parameter classes/types are not validated (e.g. String.valueOf(double) and String.valueOf(int) give different values)

So a bit of refactoring and everything is fine.

  • ReflectionUtils replaced with common-lang3 MethodUtils/FieldUtils (to keep parameter types validation clear)
  • Callable list removed - try get result at each step to optimize things a bit

I'll close #300 as that PR solves previous issue.

Thanks in advance ;)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 93.04% when pulling da6a40a on EvSpirit:extractor into fad5332 on jtwig:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants