Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve docker_cmd argumnet error #21

Merged
merged 1 commit into from Mar 25, 2024

Conversation

vladimir-babichev
Copy link
Contributor

@vladimir-babichev vladimir-babichev commented Mar 25, 2024

This PR addresses the argument error for the docker_cmd command introduced in the pre-commit version v3.7.0 by addition of required color parameter to the function in scope.

Error sample:

$ pre-commit run docker-image --all-files
Validate app directory and files.........................................Failed
- hook id: docker-image
- exit code: 1

Traceback (most recent call last):
  File "/Users/vladimir/.cache/pre-commit/repox_re6swk/py_env-python3.12/bin/docker-image", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/vladimir/.cache/pre-commit/repox_re6swk/py_env-python3.12/lib/python3.12/site-packages/hooks/docker_image.py", line 156, in main
    cmd = DOCKER.docker_cmd() + tuple(SYS_ARGV[1:])
          ^^^^^^^^^^^^^^^^^^^
TypeError: docker_cmd() missing 1 required keyword-only argument: 'color'

@jtyr jtyr merged commit 0687a67 into jtyr:main Mar 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants