Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] register_model #105

Closed
samihamdan opened this issue Dec 30, 2020 · 0 comments
Closed

[ENH] register_model #105

samihamdan opened this issue Dec 30, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@samihamdan
Copy link
Collaborator

It would be nice to have a register_model method.
This would make the api a bit nicer for using custom models and allow users to use simple names to reference a model independent from the problem_type as for all julearn models.

This also increases consistency for the julearn api between transformers and models.
@samihamdan samihamdan added the enhancement New feature or request label Dec 30, 2020
samihamdan added a commit that referenced this issue Jun 16, 2022
@samihamdan
ADD lastest for #105
b4d964a
@samihamdan samihamdan mentioned this issue Jun 16, 2022
Merged
fraimondo pushed a commit that referenced this issue Jun 17, 2022
@samihamdan
[ENH] Register model (#159)
11911cc 
* ADD model registration

* codespell

* ADD test

* ADD lastest for #105

* Bug fix scoring using dict with registered scorer

* Add overwrite to register_models

* Adjust transformer to make overwrite consistent

* Make registering more consistent

* flake8

* latest

* codespell

* Correct Docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fraimondo @samihamdan