Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Not implemented decision_function method in ExtendedDataFramePipeline #135

Closed
samihamdan opened this issue May 19, 2021 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@samihamdan
Copy link
Collaborator

samihamdan commented May 19, 2021

Describe the bug
When using scoring in run_cross_validation which need a decision function (e.g. roc_auc) we run into a bug.
The problem is that we did not implement a decision_function in the ExtendedDataFramePipeline.

To Reproduce

from seaborn import load_dataset
from julearn import run_cross_validation


df_iris = (load_dataset('iris')
           .query('species in ["versicolor", "virginica"]')
          )

X = ['sepal_length', 'sepal_width', 'petal_length']
y = 'species'
scores = run_cross_validation(
    X=X, y=y, data=df_iris, model='svm',scoring='roc_auc')

will throw:
AttributeError: 'ExtendedDataFramePipeline' object has no attribute 'decision_function'

Expected behavior
As the normal cross_validate function we should be able to use this scoring method.
The ExtendedDataFramePipeline should just use the decision_function from the used model (here svm).

Screenshots
image

System (please complete the following information):

  • OS: Linux 10/ Debian
  • Desktop Gnome 3.30.2

Additional context
Should be easy to fix.

@samihamdan samihamdan added the bug Something isn't working label May 19, 2021
@samihamdan samihamdan added this to To do in Hackathon 20/05/2021 via automation May 19, 2021
@samihamdan samihamdan moved this from To do to In progress in Hackathon 20/05/2021 May 20, 2021
samihamdan added a commit that referenced this issue May 20, 2021
@samihamdan samihamdan moved this from In progress to Waiting review in Hackathon 20/05/2021 May 20, 2021
fraimondo added a commit that referenced this issue Jul 5, 2021
* Add decision based scoring into tests

* Add decision_function #135

* Modify latest changes

Co-authored-by: Fede Raimondo <federaimondo@gmail.com>
Hackathon 20/05/2021 automation moved this from Waiting review to Done Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

1 participant