Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add BaseEstimator to TargetConfoundRemover #151

Closed
LeSasse opened this issue Mar 17, 2022 · 1 comment
Closed

[BUG] Add BaseEstimator to TargetConfoundRemover #151

LeSasse opened this issue Mar 17, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@LeSasse
Copy link
Collaborator

LeSasse commented Mar 17, 2022

Describe the bug
A clear and concise description of what the bug is. Include the error message in detail.

Currently, the TargetConfoundRemover is not a BaseEstimator, hence i get a fit_failed, because sklearn does not like it when you can't get_params().

To Reproduce
Steps to reproduce the behavior:
run_cross_validation(
...
preprocess_y="remove_confound"
...
)

Expected behavior
A clear and concise description of what you expected to happen.

Remove confounds from the target.

Screenshots
If applicable, add screenshots to help explain your problem.
Selection_103

System (please complete the following information):

  • Linux

Additional context
Add any other context about the problem here.

@LeSasse LeSasse added the bug Something isn't working label Mar 17, 2022
@LeSasse
Copy link
Collaborator Author

LeSasse commented Mar 17, 2022

Forgot to tag @samihamdan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant