Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Refactor of Julearn's Internals #145

Closed
wants to merge 45 commits into from
Closed

[WIP] Refactor of Julearn's Internals #145

wants to merge 45 commits into from

Conversation

samihamdan
Copy link
Collaborator

Due to multiple planned improvements, we wanted to change multiple co dependent things in the internals of julearn.

fraimondo and others added 30 commits June 15, 2021 12:41
@fraimondo
Test and fix WIP for #23
0064c17
@fraimondo
Add groups parameter in test: #141
4379e28
@samihamdan
Add groups to inner cv with fit_params in cross_validate #141
6872892
@samihamdan
Update latest changes
58ca440
@samihamdan
Move confounds and categorical_features to fi_params
02399ba
@samihamdan
Adjust tests to new confounds and categorical_features
6da5267
@samihamdan
formatting and clean up
a5a0a2f
@samihamdan
Add fit_predict, move fit_transform
793171e
@samihamdan
Fix formating docstring+
08a7f1a
@fraimondo @samihamdan
Refactor pipeline + confound removal (passing tests)
ec8b4a4 
Co-authored-by: Sami Hamdan <sami.hamdan@hhu.de>
@fraimondo @samihamdan
WIP: Still some tests are bad
540bf27 
Co-authored-by: Sami Hamdan <sami.hamdan@hhu.de>
@fraimondo
Fix more tests
2e9fa08
@fraimondo
WIP: confound removal apply_to
95125c2
@samihamdan
Fix throwing warning with pipeline
5045dba
@samihamdan
Make ExtendedPipeline more sklearn like using only steps in init
62a5471
@samihamdan
cleanup pipeline
3b1ff61
@samihamdan
correct flak8
446634f
@samihamdan
Fix confound removal + test
1c00c66
@samihamdan
Add propagate column_names and make preprocess use it
bb60b31
@samihamdan
Fix codespell
dfc06e0
@samihamdan
Add: prepare_data to api
3c5c589
@samihamdan
Fix docs to run, but not content
c2353e9
@samihamdan
Fix flake examples
90cd5eb
@samihamdan
Remove scratch files
f20ea68
@samihamdan
Fix Docstyle
e2ee5cc
@samihamdan
Add pipeline test
9469838
@samihamdan
remove not needed pipeline code
d50ee0f
@samihamdan
Ajust confound remover
b719ae8
@samihamdan
Improve pipeline code
6974f8d
@samihamdan
flake8
5c25156
@fraimondo fraimondo mentioned this pull request Sep 22, 2021
Closed
@fraimondo fraimondo closed this Dec 6, 2022
@fraimondo fraimondo deleted the super_duper_refactor branch July 21, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samihamdan @fraimondo