Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Change storage default parameter single_output to True #134

Closed
1 task done
fraimondo opened this issue Nov 21, 2022 · 0 comments · Fixed by #135
Closed
1 task done

[ENH]: Change storage default parameter single_output to True #134

fraimondo opened this issue Nov 21, 2022 · 0 comments · Fixed by #135
Assignees
Labels
enhancement New feature or request

Comments

@fraimondo
Copy link
Contributor

Are you requiring a new dataset or marker?

  • I understand this is not a marker or dataset request

Which feature do you want to include?

Using a Storage requires the user to specify the URI and single_output=True, which is counter-intuitive and does not make any sense.

The only reason why we want False is for the run and collect functions. Because this functions are meant to create one file per subject (single_output=False).

The fix is to set that parameter to False in those functions (if not specified by the user) and leave the default as True, so it's easier to use the python interface to read features.

How do you imagine this integrated in junifer?

Done it, will submit the PR now.

Do you have a sample code that implements this outside of junifer?

No response

Anything else to say?

No response

@fraimondo fraimondo added enhancement New feature or request triage New issues waiting to be reviewed labels Nov 21, 2022
@fraimondo fraimondo assigned fraimondo and synchon and unassigned synchon Nov 21, 2022
@fraimondo fraimondo removed the triage New issues waiting to be reviewed label Nov 21, 2022
@fraimondo fraimondo added this to the 0.0.1 (alpha 0) milestone Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants