Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enh/default single output #135

Merged
merged 6 commits into from
Nov 21, 2022
Merged

Enh/default single output #135

merged 6 commits into from
Nov 21, 2022

Conversation

fraimondo
Copy link
Contributor

@codecov
Copy link

codecov bot commented Nov 21, 2022 •
edited

Codecov Report

Merging #135 (a6c757b) into main (1aca7b8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   95.08%   95.09%           
=======================================
  Files          57       57           
  Lines        2260     2264    +4     
  Branches      424      426    +2     
=======================================
+ Hits         2149     2153    +4     
  Misses         71       71           
  Partials       40       40
Flag Coverage Δ
docs 100.00% <ø> (ø)
junifer 95.08% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
junifer/storage/base.py 94.11% <ø> (ø)
junifer/storage/pandas_base.py 100.00% <ø> (ø)
junifer/api/functions.py 98.03% <100.00%> (+0.05%) ⬆️
junifer/storage/sqlite.py 93.75% <100.00%> (ø)

@fraimondo fraimondo added ready Pull request is ready for review and merge storage Issues or pull requests related to marker storage or retrieval labels Nov 21, 2022
@github-actions
Copy link

github-actions bot commented Nov 21, 2022 •
edited

PR Preview Action v1.2.0
Preview removed because the pull request was closed.
2022-11-21 19:32 UTC

synchon
synchon reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@synchon synchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you please run black once?

@fraimondo
Copy link
Contributor Author

Looks good! Can you please run black once?

done

@synchon synchon merged commit cc861a1 into main Nov 21, 2022
@synchon synchon deleted the enh/default_single_output branch November 21, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@synchon synchon synchon approved these changes

Assignees
No one assigned
Labels
ready Pull request is ready for review and merge storage Issues or pull requests related to marker storage or retrieval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH]: Change storage default parameter single_output to True
2 participants
@fraimondo @synchon