[fix][compat] iris shaders #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `EntryListWidgetMixin.java` - now use constructor to set `renderBackground` and `renderHorizontalShadows`
lonefelidae16
commented
Aug 10, 2022
...juancarloscp52/bedrockify/mixin/client/features/panoramaBackground/EntryListWidgetMixin.java
Outdated
Show resolved
Hide resolved
* `EntryListWidgetMixin.java` - use Shadow annotation to get the original methods instead of casting `this` - use `RETURN` in At annotation of constructor - unnecessary import statement
|
update: for
|
|
Looks good! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #172
Use the constructor to set fields
renderBackgroundandrenderHorizontalShadowsthat they can be changed by other MOD. Please check the changes below:EntryListWidgetMixin.javadoNotDrawBackground(EntryListWidget)anddoNotDrawBars(EntryListWidget)were removedbedrockify$ctorwas added which targeted to constructor ofEntryListWidget